[installer] improve ws-daemon config #11164
Conversation
roboquat
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
size/S
size/M
and removed
size/S
labels
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
github-actions
bot
added
team: delivery
|
started the job as gitpod-build-pavel-10418-3.6 because the annotations in the pull request description changed |
|
/werft run 👍 started the job as gitpod-build-pavel-10418-3.7 |
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-pavel-10418-3.8 |
| runtimeMapping[value.Path] = value.Value | ||
| } | ||
| } else { | ||
| runtimeMapping[ctx.Config.Workspace.Runtime.ContainerDRuntimeDir] = "/mnt/node0" |
There was a problem hiding this comment.
This line will be executed if and only if an experimental config is given in the config file and the experimental CLI flag is set, right? (Because it's inside of the WithExperimental callback function body that will be executed contitionally).
Before this change, this mapping was the default. Is it really intended that runtimeMapping remains empty now when there is no experimental config / CLI flag? Or do I miss something?
There was a problem hiding this comment.
oops. you are right. duh, this is the second time I am getting tripped by this withExperimental thing.
There was a problem hiding this comment.
duh, this is the second time I am getting tripped by this withExperimental thing.
I'm sorry for the confusion. 😞
roboquat
added
the
deployed: workspace
Description
Improve ws-daemon config so that for SaaS we don't need to manually fix configmap, and instead use installer values.
Related Issue(s)
Related #10418
How to test
Release Notes
Documentation
Werft options: