Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatible column type in DBBlockedRepository #11175

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix incompatible column type in DBBlockedRepository #11175

merged 1 commit into from
Jul 6, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 6, 2022 •
edited

Description

Related Issue(s)

Fixes #11146

How to test

  • create a new branch + preview environment from main
  • open workspace on that branch
  • connect to DB:
    • kubectl port-forward mysql-0 3306 &
    • mysql -u gitpod -h 127.0.0.1 -p, PW: jBzVMe2w4Yi7GagadsyB (not a secret, our default PW)
  • execute both lines of migration from here
  • note how they work without any issues (prod/staging tables are empty as well)

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl geropl changed the title dev Fix incompatible column type in DBBlockedRepository Jul 6, 2022
@roboquat roboquat added size/M and removed size/S labels Jul 6, 2022
@geropl geropl marked this pull request as ready for review July 6, 2022 11:20
@geropl geropl requested a review from a team July 6, 2022 11:20
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 6, 2022
@laushinka
Copy link
Contributor

@geropl Tested and works fine, but I didn't test with a blocked repo. Should I?

laushinka
laushinka approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@laushinka laushinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again with a blocked repo. All good!

@roboquat roboquat merged commit 0e75fc7 into main Jul 6, 2022
@roboquat roboquat deleted the gpl/11146-updatedat branch July 6, 2022 13:36
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[db-sync] Cannot sync due to datetime column type (DBBlockedRepository.updatedAt)
3 participants
@geropl @laushinka @roboquat