Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the installer test issues #11181

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix the installer test issues #11181

merged 1 commit into from
Jul 7, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

The newly merged changes has some flaws that were caught a bit late. These are the changed I am making as a part of this PR:

  • The Azure DNS records take longer to propagate and hence need a longer sleep time
  • Escaping was missing around db password on Azure
  • This was caught due to the registry pre-flights, but I had missed a small change during a merge conflict resolution. The registry password for GCP is not the base64 of the service account JSON, but the string version of it. Fixed it with this PR.

Related Issue(s)

Fixes #

How to test

From a workspace opened from this PR having core-dev cluster access, you can run one of the following:

 werft run github -a cluster=aks -a skipTests=true -a deps=external -j .werft/self-hosted-installer-tests.yaml 
 werft run github -a cluster=gke -a skipTests=true -a deps=external -j .werft/self-hosted-installer-tests.yaml 

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma nandajavarma marked this pull request as ready for review July 7, 2022 08:10
@nandajavarma nandajavarma requested a review from a team July 7, 2022 08:10
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jul 7, 2022
@roboquat roboquat merged commit 9ee27b8 into main Jul 7, 2022
@roboquat roboquat deleted the nvn/fix-test-bugs branch July 7, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants