Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-daemon] Fix extraction of process arguments #11184

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[ws-daemon] Fix extraction of process arguments #11184

merged 1 commit into from
Jul 6, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 6, 2022

Related Issue(s)

goroutine 155927 [running]:
github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup.extractCommand(0x22f7190?)
	github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup/plugin_process_priority_v2.go:135 +0xd0
github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup.determineProcessType(0x22f7190?)
	github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup/plugin_process_priority_v2.go:104 +0x25
github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup.(*ProcessPriorityV2).Apply.func1()
	github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup/plugin_process_priority_v2.go:83 +0x8ca
created by github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup.(*ProcessPriorityV2).Apply
	github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup/plugin_process_priority_v2.go:52 +0x18c

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@aledbf aledbf marked this pull request as ready for review July 6, 2022 23:40
@aledbf aledbf requested a review from a team July 6, 2022 23:40
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 6, 2022
@roboquat roboquat merged commit f090bc7 into main Jul 6, 2022
@roboquat roboquat deleted the aledbf/args branch July 6, 2022 23:52
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aledbf @sagor999 @roboquat