Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-daemon] Add additional process type priorities #11186

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[ws-daemon] Add additional process type priorities #11186

merged 1 commit into from
Jul 7, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 6, 2022 •
edited

Description

xref #11159 (comment)

How to test

  • Open a workspace using VS Code Desktop and check the NI value of processes

Release Notes

NONE

Werft options:

  • /werft with-preview

cc @akosyakov

@aledbf
Copy link
Member Author

aledbf commented Jul 7, 2022

Screenshot from 2022-07-06 20-11-04

@aledbf aledbf marked this pull request as ready for review July 7, 2022 00:11
@aledbf aledbf requested a review from a team July 7, 2022 00:11
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 7, 2022
@jenting
Copy link
Contributor

jenting commented Jul 7, 2022 •
edited by werft-gitpod-dev-com bot

/werft with-preview

👎 unknown command: with-preview
Use /werft help to list the available commands

@jenting
Copy link
Contributor

jenting commented Jul 7, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-pt.2
(with .werft/ from main)

jenting
jenting approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with cgroup v2
image

@roboquat roboquat merged commit 3d7bc33 into main Jul 7, 2022
@roboquat roboquat deleted the aledbf/pt branch July 7, 2022 03:45
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aledbf @jenting @roboquat