[ws-manager] log errors as warnings during exponential backoff #11216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we have an error after backoff, log it as an error, otherwise log errors during backoff as a warning.
The errors we encounter while doing exponential backoff should be treated as warnings, because they don't necessarily require action. This way, the error at the end (signifying we could not start a workspace) becomes more valuable.
For example, during a traffic shift, these were showing as errors, but that was false (we were waiting for nodes to scale-up).
Related Issue(s)
Fixes # n/a
How to test
kubectl cordon
the node (this is already done), so a workspace pod cannot be scheduledkubectl logs deployment/ws-manager
that you see the warnings during backoff, the error at the end (after backoff), and that pod we log is a string representation of the pod object, rather than a byte array.Release Notes
Documentation
Werft options: