Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usage] Add initial gRPC API #11221

Merged
merged 1 commit into from
Jul 8, 2022
Merged

[usage] Add initial gRPC API #11221

merged 1 commit into from
Jul 8, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Add an initial version of a components/usage-api package that defines a gRPC API for the usage component.

The layout of the package is taken from the analogous public-api package.

Only Go code generation is included here; typescript can follow as required later.

Related Issue(s)

Part of #10324

How to test

Release Notes

NONE

Documentation

@andrew-farries andrew-farries requested review from a team July 8, 2022 06:59
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Jul 8, 2022
@andrew-farries andrew-farries changed the title Add initial gRPC API [usage] Add initial gRPC API Jul 8, 2022
@andrew-farries
Copy link
Contributor Author

/hold

@easyCZ
Copy link
Member

easyCZ commented Jul 8, 2022

It's unclear why the installer changes are in this PR, do you know?

@andrew-farries
Copy link
Contributor Author

It's unclear why the installer changes are in this PR, do you know?

It's because of the transitive dependency installer -> usage -> usage API.

Arguably the changes to the usage component (adding the dependency on the usage API) shouldn't be in this PR, but in the follow up #11224 instead.

Happy to sort that out here if you think it's worth it.

Add Placeholder .proto files and script to generate Go client/server
SDKs.

Adapted from the `public-api` component.
@andrew-farries
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit c83333f into main Jul 8, 2022
@roboquat roboquat deleted the af/initial-usage-grpc-api branch July 8, 2022 10:55
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/XXL team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants