Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function:getSSHPublicKeys scope to vscode client #11246

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Add function:getSSHPublicKeys scope to vscode client #11246

merged 1 commit into from
Jul 11, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Jul 8, 2022 •
edited

Description

Add function:getSSHPublicKeys scope for vscode client so we can improve ssh connection experience in gitpod-desktop extension

Release Notes

NONE
  • /werft with-preview

@jeanp413 jeanp413 requested a review from a team July 8, 2022 20:33
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 8, 2022
@jeanp413
Copy link
Member Author

jeanp413 commented Jul 8, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jp-vscode-getsshpublickeys.1
(with .werft/ from main)

@jeanp413 jeanp413 mentioned this pull request Jul 9, 2022
Merged
geropl
geropl approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat roboquat merged commit 6acb5f3 into main Jul 11, 2022
@roboquat roboquat deleted the jp/vscode-getSSHPublicKeys branch July 11, 2022 09:30
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeanp413 @geropl @roboquat