Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Analytics] move "project_created" call to projects-service.ts and add project ID #11254

Merged
merged 1 commit into from
Jul 11, 2022
Merged

[Analytics] move "project_created" call to projects-service.ts and add project ID #11254

merged 1 commit into from
Jul 11, 2022

Conversation

jakobhero
Copy link
Member

@jakobhero jakobhero commented Jul 9, 2022 •
edited

Description

Moves the tracking call for project_created to projects-service.ts in order to have access and use the project's ID.

How to test

  1. Open a preview environment, sign up, and create a project
  2. Go to the debugger of Staging Untrusted and ensure that a project_created call was fired and that it contains the project's ID as one of its properties

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@jakobhero jakobhero marked this pull request as ready for review July 9, 2022 17:30
@jakobhero jakobhero requested a review from a team July 9, 2022 17:30
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 9, 2022
@roboquat roboquat merged commit ac3bde2 into main Jul 11, 2022
@roboquat roboquat deleted the jh/track-project-id branch July 11, 2022 05:48
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobhero @andrew-farries @roboquat