-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration for new usage table #11311
Conversation
started the job as gitpod-build-af-add-usage-table.2 because the annotations in the pull request description changed |
started the job as gitpod-build-af-add-usage-table.3 because the annotations in the pull request description changed |
@Column({ | ||
type: "timestamp", | ||
precision: 6, | ||
default: () => "CURRENT_TIMESTAMP(6) ON UPDATE CURRENT_TIMESTAMP(6)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the defaults here, I think we want this to be required but not to default to anything
31c8b9e
to
bac4ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just build is unhappy.
/hold
in case there's further changes you're looking to make but it looked complete to me (minus CI)
Thanks. I'm going to get rid of the defaults for the timestamp fields and make |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-af-add-usage-table.6 |
/unhold |
Description
Define the schema and add the migration for a new
d_b_workspace_instance_usage
table to store workspace usage data.Related Issue(s)
Part of #10323
How to test
Connect to the database in the preview environment for this branch and see the new table in the database:
Release Notes
Documentation
Werft options: