Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance workspace integration test #11333

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Enhance workspace integration test #11333

merged 2 commits into from
Jul 13, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jul 13, 2022 •
edited

Description

Search the job with with-preview annotation.

Related Issue(s)

Fixes #

How to test

Release Notes

None

Documentation

None

Werft options:

  • /werft with-preview

@jenting jenting force-pushed the jenting/enhance-wk-integration-test branch from 257eef3 to c70e175 Compare July 13, 2022 00:55
@jenting jenting force-pushed the jenting/enhance-wk-integration-test branch 2 times, most recently from 80169e3 to 03a149f Compare July 13, 2022 02:08
@jenting jenting marked this pull request as ready for review July 13, 2022 02:16
@jenting jenting requested a review from a team July 13, 2022 02:16
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 13, 2022
mustard-mh
mustard-mh reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not recommended to do this, but rather to record the commitID and send it to the slack before committing the new commit

One problem with this is that the werft job sometimes ignores the cache, and our image names are dependent on the commit id, which can cause a series of strange problems, such as we may inadvertently replace some images that are otherwise good

e.g. some image need download resource from other website, we need prevent overwrite exist image

@jenting
Copy link
Contributor Author

jenting commented Jul 13, 2022 •
edited by werft-gitpod-dev-com bot

🤔 But adding a new commit to a new branch, we can't find the original main branch commit id.
Now, the workspace integration test job runs on the main branch (commit X) + creates a new branch (B) + a commit (commit Y). In werft UI, we could only know the commit Y. However, the branch (B) is deleted on the repo, therefore, we can't know what the commit X ID is.

@mustard-mh
Copy link
Contributor

In werft UI, we could only know the commit Y. However, the branch (B) is deleted on the repo, therefore, we can't know what the commit X ID is.

why? e.g. https://werft.gitpod-dev.com/job/gitpod-workspace-run-integration-tests-main.55
you got commit id cfe358bf570e819a632f0239eb25ac0f288477bb, link, this is your commit X

if you visit https://werft.gitpod-dev.com/job/gitpod-build-wk-inte-test-20220710000011.0 you got 46bfb400465a020184921da8f3b89675ed5df95c that is commit Y

so if you want commit X, use https://werft.gitpod-dev.com/job/gitpod-workspace-run-integration-tests-main.55 this one is enough

@mustard-mh
Copy link
Contributor

/hold

@jenting
Found the job with with-preview annotation
364ad18 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Remove unnecessary install oci-tool
fcbc4d0 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting force-pushed the jenting/enhance-wk-integration-test branch from 03a149f to fcbc4d0 Compare July 13, 2022 12:12
@roboquat roboquat added size/XS and removed size/S labels Jul 13, 2022
@jenting
Copy link
Contributor Author

jenting commented Jul 13, 2022 •
edited

In werft UI, we could only know the commit Y. However, the branch (B) is deleted on the repo, therefore, we can't know what the commit X ID is.

why? e.g. https://werft.gitpod-dev.com/job/gitpod-workspace-run-integration-tests-main.55 you got commit id cfe358bf570e819a632f0239eb25ac0f288477bb, link, this is your commit X

if you visit https://werft.gitpod-dev.com/job/gitpod-build-wk-inte-test-20220710000011.0 you got 46bfb400465a020184921da8f3b89675ed5df95c that is commit Y

so if you want commit X, use https://werft.gitpod-dev.com/job/gitpod-workspace-run-integration-tests-main.55 this one is enough

Ugh, that makes sense. Thanks, @mustard-mh. Removing the commit.

@jenting jenting requested a review from mustard-mh July 13, 2022 12:13
@jenting
Copy link
Contributor Author

jenting commented Jul 13, 2022

/unhold

mustard-mh
mustard-mh approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 425e4bb into main Jul 13, 2022
@roboquat roboquat deleted the jenting/enhance-wk-integration-test branch July 13, 2022 20:19
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

@mustard-mh mustard-mh mustard-mh approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jenting @mustard-mh @sagor999 @roboquat