Extract gRPC ClientCallMetrics into protocol #11342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
changed the title
geropl
force-pushed
the
gpl/grpc-metrics
branch
2 times, most recently
from
94b2c6c
to
cbfdd78
Compare
geropl
requested review from
aledbf,
sagor999,
csweichel and
corneliusludmann
as code owners
sagor999
approved these changes
Jul 14, 2022
aledbf
approved these changes
Jul 15, 2022
|
@geropl Rebase please. |
easyCZ
approved these changes
Jul 19, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During work on #10325 it became apparent we had duplicate/non-reusable code in various places.
This PR moves it into a central place (
gitpod-protocol/src/util/grpc.ts) and makes use of it across the code base.Related Issue(s)
Context: #10325
How to test
Release Notes
Documentation
Werft options: