Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hasReadAccess for Bitbucket #11359

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Implement hasReadAccess for Bitbucket #11359

merged 1 commit into from
Jul 14, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Jul 13, 2022 •
edited

Description

As described in #11190 this PR implements the missing BitbucketRepositoryProvider.hasReadAccess

Related Issue(s)

Fixes #11190

How to test

Note, those tests are not executed in werft. One need to drive them manually.

  • grab an OAuth2 token for bitbucket.org and set it in you env using this command: 
    export GITPOD_TEST_TOKEN_BITBUCKET='{ "value": "FOOBAR=", "username": "x-token-auth", "scopes": []  }'
  • run test 
     yarn mocha --opts mocha.opts /workspace/gitpod/components/server/src/bitbucket/bitbucket-repository-provider.spec.ts

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@AlexTugarev AlexTugarev marked this pull request as ready for review July 14, 2022 07:11
@AlexTugarev AlexTugarev requested a review from a team July 14, 2022 07:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 14, 2022
@geropl
Copy link
Member

geropl commented Jul 14, 2022

@AlexTugarev How do I get an oauth token on bitbucket.org? Onyl found their "App PAssword" section in the interface... 🙄

@geropl geropl self-assigned this Jul 14, 2022
geropl
geropl approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works: nice! 🚀

@roboquat roboquat merged commit 4b62fc0 into main Jul 14, 2022
@roboquat roboquat deleted the at/bb-hasReadAccess branch July 14, 2022 08:55
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees

@geropl geropl

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BitBucket: implement hasReadAccess
3 participants
@AlexTugarev @geropl @roboquat