Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baseserver] do not log grpc messages unless they contain an error #11388

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

sagor999
Copy link
Contributor

Description

This fixes log spam like this one:
"message":"finished unary call with code OK"

Related Issue(s)

Fixes #

How to test

Release Notes

none

Documentation

Werft options:

  • /werft with-preview

@sagor999 sagor999 requested review from a team July 14, 2022 19:16
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jul 14, 2022
@roboquat roboquat merged commit dc94adb into main Jul 14, 2022
@roboquat roboquat deleted the pavel/grpc-log-fix branch July 14, 2022 19:26
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants