Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify configuration of git setting safe.directory #11417

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Simplify configuration of git setting safe.directory #11417

merged 1 commit into from
Jul 19, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 15, 2022 •
edited

Description

logs: https://cloudlogging.app.goo.gl/Wr2SmPaFz7EVu4zb6

How to test

  • Workspaces should open and work as expected

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf
Copy link
Member Author

aledbf commented Jul 15, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.1
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Jul 15, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.3
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Jul 15, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.7
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Jul 15, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.8
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Jul 15, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.10
(with .werft/ from main)

@aledbf aledbf force-pushed the aledbf/git branch 4 times, most recently from 4638960 to d4b55ab Compare July 16, 2022 15:54
@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.22
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review July 16, 2022 16:22
@aledbf aledbf requested a review from a team July 16, 2022 16:22
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 16, 2022
@jenting
Copy link
Contributor

jenting commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.25
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.26
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-aledbf-git.27
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

Not sure why, but I can't open the workspace 🤔

Events:
  Type     Reason     Age                   From               Message
  ----     ------     ----                  ----               -------
  Normal   Scheduled  20m                   default-scheduler  Successfully assigned default/ws-ec91d63d-d37f-416b-9d41-eb3aaafcfa18 to aledbf-git
  Normal   Pulling    20m                   kubelet            Pulling image "reg.aledbf-git.preview.gitpod-dev.com:30393/remote/ec91d63d-d37f-416b-9d41-eb3aaafcfa18"
  Normal   Pulled     19m                   kubelet            Successfully pulled image "reg.aledbf-git.preview.gitpod-dev.com:30393/remote/ec91d63d-d37f-416b-9d41-eb3aaafcfa18" in 56.668016695s
  Normal   Created    19m                   kubelet            Created container workspace
  Normal   Started    19m                   kubelet            Started container workspace
  Warning  Unhealthy  50s (x1139 over 19m)  kubelet            Readiness probe failed: Get "http://10.20.248.120:22999/_supervisor/v1/status/content/wait/true": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022

/hold

@atduarte
Copy link
Contributor

@aledbf Release Notes content are not relevant for the end user, we should remove.

@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.31
(with .werft/ from main)

@aledbf aledbf requested a review from a team July 18, 2022 16:31
@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.33
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.35
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.37
(with .werft/ from main)

@aledbf aledbf force-pushed the aledbf/git branch 2 times, most recently from f7fe4ce to 34c9ac0 Compare July 18, 2022 18:23
@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.40
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.42
(with .werft/ from main)

@sagor999
Copy link
Contributor

@aledbf I am going to mark this PR as draft, as it seems like you are still actively working on it. It will be included in the next cluster deploy (gen56) now. Let me know if this is a critical fix and we need to get it into gen55.

@sagor999 sagor999 marked this pull request as draft July 18, 2022 18:58
@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022

Let me know if this is a critical fix and we need to get it into gen55.

It is.

@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-aledbf-git.44
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review July 18, 2022 19:28
@aledbf
Copy link
Member Author

aledbf commented Jul 18, 2022

@sagor999 ready for review

sagor999
sagor999 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested in preview env, workspaces start and stop, untracked changes preserved and restored.

@roboquat roboquat merged commit 797f440 into main Jul 19, 2022
@roboquat roboquat deleted the aledbf/git branch July 19, 2022 15:23
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

@mustard-mh mustard-mh mustard-mh approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: IDE team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aledbf @jenting @atduarte @sagor999 @mustard-mh @roboquat