Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Fix tracing and logging when aborting prebuilds on newer push #11432

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[server] Fix tracing and logging when aborting prebuilds on newer push #11432

merged 1 commit into from
Jul 18, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 18, 2022

Description

We were missing a span.finish(). Also, added a log line for traceability.

Related Issue(s)

Fixes #

How to test

  • see that it builds

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl geropl requested a review from a team July 18, 2022 07:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 18, 2022
@roboquat roboquat merged commit 54914fb into main Jul 18, 2022
@roboquat roboquat deleted the gpl/send-span branch July 18, 2022 07:24
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geropl @andrew-farries @roboquat