-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[usage] Add user, workspace, project, type, class to WorkspaceInstanceUsage in go #11444
Conversation
a416cb9
to
c3a81a1
Compare
GenerationID int `gorm:"column:generationId;type:int;" json:"generationId"` | ||
|
||
// deleted is used by db-sync | ||
_ bool `gorm:"column:deleted;type:tinyint;default:0;" json:"deleted"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's used by db-sync, we don't need set/read it so we use _
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually wrong. Because we're using the update with Conflict handling, SQL complains when there's no value set so we've gotta keep it as a Real field, we just don't need to set it.
732b2af
to
2e49be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
b2fabdb
to
704369e
Compare
...onents/gitpod-db/src/typeorm/migration/1658144661198-WorkspaceInstanceUsageAddExtraFields.ts
Outdated
Show resolved
Hide resolved
704369e
to
db2d281
Compare
db2d281
to
bfe951f
Compare
/unhold |
Description
Related Issue(s)
Defined in https://github.com/gitpod-io/gitpod/pull/11439/files
How to test
Release Notes
Documentation
Werft options: