Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usage] Add user, workspace, project, type, class to WorkspaceInstanceUsage in go #11444

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jul 18, 2022

Description

Related Issue(s)

Defined in https://github.com/gitpod-io/gitpod/pull/11439/files

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ requested a review from a team July 18, 2022 14:32
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 18, 2022
@easyCZ easyCZ force-pushed the mp/usage-ws-usage-extra-fields branch 3 times, most recently from a416cb9 to c3a81a1 Compare July 18, 2022 14:42
@roboquat roboquat added size/M and removed size/S labels Jul 18, 2022
GenerationID int `gorm:"column:generationId;type:int;" json:"generationId"`

// deleted is used by db-sync
_ bool `gorm:"column:deleted;type:tinyint;default:0;" json:"deleted"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's used by db-sync, we don't need set/read it so we use _

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually wrong. Because we're using the update with Conflict handling, SQL complains when there's no value set so we've gotta keep it as a Real field, we just don't need to set it.

@easyCZ easyCZ force-pushed the mp/usage-ws-usage-extra-fields branch 2 times, most recently from 732b2af to 2e49be0 Compare July 18, 2022 15:00
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@easyCZ easyCZ force-pushed the mp/usage-ws-usage-extra-fields branch 2 times, most recently from b2fabdb to 704369e Compare July 19, 2022 06:27
@easyCZ easyCZ force-pushed the mp/usage-ws-usage-extra-fields branch from 704369e to db2d281 Compare July 19, 2022 06:46
@easyCZ easyCZ force-pushed the mp/usage-ws-usage-extra-fields branch from db2d281 to bfe951f Compare July 19, 2022 06:47
@easyCZ
Copy link
Member Author

easyCZ commented Jul 19, 2022

/unhold

@roboquat roboquat merged commit ce2d00d into main Jul 19, 2022
@roboquat roboquat deleted the mp/usage-ws-usage-extra-fields branch July 19, 2022 06:58
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants