Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Tiny fix to use variable rather than literal value in test #11497

Merged
merged 1 commit into from
Jul 20, 2022
Merged

[usage] Tiny fix to use variable rather than literal value in test #11497

merged 1 commit into from
Jul 20, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Use variable instead of equivalent constant.

How to test

unit tests.

Release Notes

NONE

@andrew-farries andrew-farries requested a review from a team July 20, 2022 11:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 20, 2022
geropl
geropl approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do this! 💪 😄

@roboquat roboquat merged commit 071f60f into main Jul 20, 2022
@roboquat roboquat deleted the af/tiny-test-fix branch July 20, 2022 11:17
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-farries @geropl @roboquat