Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team reviews in Jetbrains auto updates #11529

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jul 21, 2022

Description

Fixes the incorrect behavior described in #11496 (comment).

How to test

Sadly, this can't be tested easily, but the way I tested is I tried using the GitHub API and when I didn't provide gitpod-io/ it worked for requesting reviews.

Release Notes

NONE

Werft options:

  • /werft with-preview

Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct according to the description and example provided about "team-reviewers" in the peter-evans/create-pull-request readme.

@roboquat roboquat merged commit e671cc8 into main Jul 21, 2022
@roboquat roboquat deleted the ft/fix-team-review-jb-update branch July 21, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants