Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] move workspaceImage out of experimental config #11531

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

nandajavarma
Copy link
Contributor

@nandajavarma nandajavarma commented Jul 21, 2022

Description

This PR moves out options to specify the default workspace image and the allowList of private image registries out of the experimental section.
The workspace image and the allow list for the registry can be specified as follows:

workspace:
  workspaceImage: 691173103445.dkr.ecr.eu-west-1.amazonaws.com/691173103445.dkr.ecr.eu-west-1.amazonaws.com/busybox:new
containerRegistry:
  privateBaseImageAllowList:
    - 691173103445.dkr.ecr.eu-west-1.amazonaws.com

Related Issue(s)

Fixes #10791
Fixes #11408

How to test

  • Open this PR in a gitpod workspace with access to the core-dev cluster.
  • Download the replicated license corresponding to this channel.
  • mkdir -p installer/licenses/nvn/
  • cp path/to/replicatedlicense installer/licenses/nvn/fix-11408.yaml`
werft run github -s installer/licenses/nvn/fix-11408.yaml -j .werft/eks-installer-tests.yaml -a preview=true -a channel=nvn/fix-11408 -a skipTests=true -a deps=external
  • You will find the kubeconfig content under the get-results tab of the task on werft.
  • Connect the cluster, open KOTS CLI and provide the above config as config_patch.yaml

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma
Copy link
Contributor Author

nandajavarma commented Jul 21, 2022

/werft run no-preview publish-to-kots

👍 started the job as gitpod-build-nvn-fix-11408.17
(with .werft/ from main)

@nandajavarma nandajavarma marked this pull request as ready for review July 21, 2022 15:36
@nandajavarma nandajavarma requested review from a team July 21, 2022 15:36
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Jul 21, 2022
@andrew-farries andrew-farries self-assigned this Jul 22, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine - just a question about deprecation vs removal.

Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Have you created a deprecation task and assigned to a future milestone? I'd suggest putting one in the December milestone similar to #11124. Also, link it to this PR so it's easily findable when we forget everything in future

@roboquat roboquat merged commit ec2f934 into main Jul 27, 2022
@roboquat roboquat deleted the nvn/fix-11408 branch July 27, 2022 07:40
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jul 28, 2022
@1cor13
Copy link

1cor13 commented Jul 10, 2023

Do you have an example gitpod.yml on how I can use my private image hosted on dockerhub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/L team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
5 participants