Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraform] update the disk size in eks module #11536

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

nandajavarma
Copy link
Contributor

Description

Currently, when using the EKS module, the disk_size field set doesn't change the value. This is because templates are getting created for both the node pools. To change the disk size in the template as well, we define block_device_mappings for both the managed node pools

Related Issue(s)

Partly fixes #11533 (not to be closed)

How to test

Documentation task is still TODO for terraform modules.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma nandajavarma requested a review from a team July 21, 2022 13:11
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jul 21, 2022
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat roboquat merged commit 3fdb0a5 into main Jul 22, 2022
@roboquat roboquat deleted the nvn/fix-11533-1 branch July 22, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync AWS terraform module with reference architecture
3 participants