Refactor Manager StartWorkspace #11547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Jul 22, 2022
| @@ -117,16 +117,17 @@ export class PromisifiedWorkspaceManagerClient implements Disposable { | |||
| this.client.startWorkspace( | |||
| request, | |||
| withTracing({ span }), | |||
| this.getDefaultUnaryOptions(), | |||
| { | |||
| // Important!!!!: client timeout must be higher than ws-manager to be able to process any error | |||
sagor999
approved these changes
Jul 22, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The call
startWorkspacehere uses a timeout of 30s that is not respected here and the consequence is that we never remove the annotationgitpod.io/attemptingToCreateand ws-daemon never creates the socket in the workspace.Similar to #11327
This is also the place that introduces the behavior of why some workspaces stay in
Preparing workspace …and after a refresh, we can open the IDE.With this change, we don't see the behavior in the workspace cluster, but we still require a refresh to open the IDE.
Release Notes
Documentation
Werft options: