Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UBP] View without data or access #11554

Merged
merged 1 commit into from
Jul 22, 2022
Merged

[UBP] View without data or access #11554

merged 1 commit into from
Jul 22, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Jul 22, 2022 •
edited

Description

This handles the views when there is either no data or no access.

NO DATA NO ACCESS
Screenshot 2022-07-22 at 10 20 28 Screenshot 2022-07-22 at 11 00 04

Related Issue(s)

Fixes #11495

How to test

  1. Join https://lau-usage-de27c2b151.preview.gitpod-dev.com/teams/join?inviteId=e3fe8d85-f7a8-4b83-b7b4-0d2d20bac787.
  2. As member, you should see the "Please request access" message.
  3. After that I can set you as owner, and then you'll see the "No sessions found" view.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview with-billing

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-usage-empty-11495.3 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/L and removed size/M labels Jul 22, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-usage-empty-11495.5 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka laushinka changed the title view without data [UBP] View without data or access Jul 22, 2022
@laushinka laushinka marked this pull request as ready for review July 22, 2022 09:05
@laushinka laushinka requested a review from a team July 22, 2022 09:05
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 22, 2022
easyCZ
easyCZ reviewed Jul 22, 2022
View reviewed changes
components/dashboard/src/teams/TeamUsage.tsx
</div>
<div className="my-auto">
<span className="text-gray-400">
{moment(new Date(usage.startTime).toDateString()).fromNow()}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

easyCZ
easyCZ approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding hold in case you want a Product Manager to TAL.

/hold

@easyCZ easyCZ self-assigned this Jul 22, 2022
jldec
jldec suggested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the copy for the "no access" case to

"Access to usage details is restricted to team owners"

@jldec
Copy link
Contributor

jldec commented Jul 22, 2022

thanks approved.

@roboquat roboquat merged commit 60cd9d5 into main Jul 22, 2022
@roboquat roboquat deleted the lau/usage-empty-11495 branch July 22, 2022 10:38
This was referenced Jul 22, 2022
Closed
Closed
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldec jldec jldec approved these changes

@easyCZ easyCZ easyCZ approved these changes

Assignees

@easyCZ easyCZ

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add usage page empty state
4 participants
@laushinka @jldec @easyCZ @roboquat