Add spending limit notifications #11556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-at-usage-notification.1 |
AlexTugarev
force-pushed
the
at/usage-notification
branch
from
9b3e742
to
70576aa
Compare
AlexTugarev
force-pushed
the
at/usage-notification
branch
from
70576aa
to
85b7cf9
Compare
geropl
reviewed
Jul 22, 2022
| async getNotifications(ctx: TraceContext): Promise<string[]> { | ||
| const result = await super.getNotifications(ctx); | ||
| const user = this.checkAndBlockUser("getNotifications"); | ||
| if (user.usageAttributionId) { |
There was a problem hiding this comment.
This has to be replaced by the getBillingMode(user) method. But as it's not there it, this is fine.
geropl
reviewed
Jul 22, 2022
| const user = this.checkAndBlockUser("getNotifications"); | ||
| if (user.usageAttributionId) { | ||
| const allSessions = await this.listBilledUsage(ctx, user.usageAttributionId); | ||
| const totalUsage = allSessions.map((s) => s.credits).reduce((a, b) => a + b, 0); |
There was a problem hiding this comment.
Ideally we'd get that from the service as well, but we can replace that once we do.
|
/werft run 👍 started the job as gitpod-build-at-usage-notification.8 |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the basic notification to signal reaching of spending limits as described in #11404. The static message is provided by the server API.
Screenshot shows a notification when a spending limit of 1 is reached.
The notification is dismissible, but will reappear on reload until the condition is resolved.
Related Issue(s)
Relates to #11404
How to test
usagecomponentRelease Notes
Documentation
Werft options: