Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usage] Fix usage query #11582

Merged
merged 1 commit into from
Jul 23, 2022
Merged

[usage] Fix usage query #11582

merged 1 commit into from
Jul 23, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jul 22, 2022

Description

Before, the extra range filters would eventually be appended as top level OR, which would lead to returning results which didn't actually match the Attribution ID

Related Issue(s)

Fixes #

How to test

Unit test
Test as a regression, remove the changes to the implementation and run the test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ requested a review from a team July 22, 2022 15:26
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 22, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Nice find!

@geropl geropl self-assigned this Jul 22, 2022
@roboquat roboquat merged commit f9ac10a into main Jul 23, 2022
@roboquat roboquat deleted the mp/usage-fix-query branch July 23, 2022 01:56
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants