Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace workspace search alert #11592

Merged
merged 1 commit into from Jul 26, 2022
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jul 22, 2022

Description

This will replace the custom alert component added in #8632 for searching workspaces only by their IDs.

Related Issue(s)

Fixes #8701

How to test

  1. Go to /admin/workspaces
  2. Breathe and enjoy the hidden power of components

Screenshots

BEFORE AFTER
Screenshot 2022-07-23 at 12 41 08 AM (2) Screenshot 2022-07-23 at 12 41 27 AM (2)

Release Notes

Replce workspace search alert

Documentation

Werft options:

  • /werft with-preview

@gtsiolis gtsiolis requested a review from a team July 22, 2022 21:45
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 22, 2022
@gtsiolis gtsiolis force-pushed the gt/replace-workspace-search-alert branch from b037e0e to 6b850b0 Compare July 22, 2022 22:01
@gtsiolis gtsiolis changed the title Replce workspace search alert Replace workspace search alert Jul 22, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧡

@andrew-farries
Copy link
Contributor

/hold (I think this is blocking the merge pool).

@easyCZ
Copy link
Member

easyCZ commented Jul 26, 2022

I've pushed a fix for this which was failing the build.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-replace-workspace-search-alert.4 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jul 26, 2022

Thanks for taking a look @easyCZ, @andrew-farries, and @geropl! 🏀

Removing the hold. 🚂

/unhold

@easyCZ
Copy link
Member

easyCZ commented Jul 26, 2022

Build failed due to registry facade

/werft run with-preview

👍 started the job as gitpod-build-gt-replace-workspace-search-alert.5
(with .werft/ from main)

@easyCZ easyCZ force-pushed the gt/replace-workspace-search-alert branch from 16aac9b to eaa779e Compare July 26, 2022 11:35
@roboquat roboquat merged commit 46ba893 into main Jul 26, 2022
@roboquat roboquat deleted the gt/replace-workspace-search-alert branch July 26, 2022 11:48
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve alert component on the user page in admin dashboard
5 participants