Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration-test] re-enable jetbrains inte test #11627

Merged
merged 1 commit into from
Jul 29, 2022
Merged

[integration-test] re-enable jetbrains inte test #11627

merged 1 commit into from
Jul 29, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jul 25, 2022 •
edited

Description

Re-enable jetbrains integration test, also merge vscode/jetbrains integration test

Related Issue(s)

Fixes #

How to test

  1. open this branch in gitpod.io
  2. run werft run github -j .werft/ide-integration-tests-startup.yaml
  3. see job result

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@iQQBot iQQBot force-pushed the pd/reenable-jb-test branch 3 times, most recently from d68b20a to deb7bd9 Compare July 26, 2022 05:42
@iQQBot iQQBot mentioned this pull request Jul 26, 2022
Merged
1 task
@iQQBot iQQBot marked this pull request as ready for review July 26, 2022 06:01
@iQQBot iQQBot requested a review from a team July 26, 2022 06:01
@mustard-mh mustard-mh requested review from mustard-mh and removed request for mustard-mh July 26, 2022 06:05
@iQQBot
Copy link
Contributor Author

iQQBot commented Jul 26, 2022

/hold

This PR need to wait #11624 approved and rebase to main after merged

@iQQBot iQQBot force-pushed the pd/large-vm branch 2 times, most recently from 16002f7 to 2db9752 Compare July 26, 2022 06:15
Base automatically changed from pd/large-vm to main July 27, 2022 02:04
@roboquat roboquat added size/XXL and removed size/XL labels Jul 27, 2022
@roboquat roboquat added size/XL and removed size/XXL labels Jul 27, 2022
@iQQBot
Copy link
Contributor Author

iQQBot commented Jul 27, 2022

/unhold

@mustard-mh
Copy link
Contributor

I tested three times, and two of them failed with test cases

https://werft.gitpod-dev.com/job/gitpod-custom-pd-reenable-jb-test.6 failed
https://werft.gitpod-dev.com/job/gitpod-custom-pd-reenable-jb-test.7 failed
https://werft.gitpod-dev.com/job/gitpod-custom-pd-reenable-jb-test.8 succeed

image

@iQQBot
Copy link
Contributor Author

iQQBot commented Jul 27, 2022 •
edited by werft-gitpod-dev-com bot

@mustard-mh I made some change, could you please take a look again? 🙏

@iQQBot
Copy link
Contributor Author

iQQBot commented Jul 29, 2022

@mustard-mh I remove debug commit, let's merge it first, and try to improve at next PR

@mustard-mh
Copy link
Contributor

mustard-mh commented Jul 29, 2022 •
edited

@mustard-mh I remove debug commit, let's merge it first, and try to improve at next PR

Since these debug commits were pushed, jobs all succeed 🙈, that's what blocked me.

mustard-mh
mustard-mh approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 4419c85 into main Jul 29, 2022
@roboquat roboquat deleted the pd/reenable-jb-test branch July 29, 2022 08:21
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustard-mh mustard-mh mustard-mh approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XL team: IDE
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iQQBot @mustard-mh @roboquat