Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-manager] Refactor connectToWorkspaceDaemon #11661

Merged
merged 2 commits into from
Jul 27, 2022
Merged

[ws-manager] Refactor connectToWorkspaceDaemon #11661

merged 2 commits into from
Jul 27, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 26, 2022 •
edited

Description

Reverts #11517 and improve error messages

Screenshot from 2022-07-26 19-14-10

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf aledbf marked this pull request as ready for review July 27, 2022 00:44
@aledbf aledbf requested a review from a team July 27, 2022 00:44
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 27, 2022
@kylos101
Copy link
Contributor

Loadgen test with scale-up:
image

@utam0k
Copy link
Contributor

utam0k commented Jul 27, 2022

Why do we need to revert #11517? I ask because if we revert it, after all, we have to wait until ws-damon pod running, don't we?

kylos101
kylos101 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat roboquat merged commit 3d691fa into main Jul 27, 2022
@roboquat roboquat deleted the aledbf/wsmd branch July 27, 2022 00:51
@aledbf
Copy link
Member Author

aledbf commented Jul 27, 2022

Why do we need to revert #11517? I ask because if we revert it, after all, we have to wait until ws-damon pod running, don't we?

We updated ws-daemon with the CI image.

@kylos101
Copy link
Contributor

Related to #11664

@sagor999
Copy link
Contributor

We updated ws-daemon with the CI image.

I don't understand what you mean. :(
I am also curious why the check for if pod is running is not needed or was bad?

@aledbf
Copy link
Member Author

aledbf commented Jul 27, 2022

I don't understand what you mean. :(

I am sorry. I updated the ws-daemon daemonset image using the werft image from this PR.

I am also curious why the check for if pod is running is not needed or was bad?

It was bad. That said, we need to review the use of a pool for the connections.

@sagor999
Copy link
Contributor

Sorry for being annoying, but for posterity, why was that change bad?
Since it makes sense to check if pod is in running state. Unless that ready state is floppy? Or not reliable and gives false positives somehow?

@kylos101 kylos101 mentioned this pull request Jul 27, 2022
Closed
@aledbf aledbf mentioned this pull request Aug 1, 2022
Closed
1 task
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aledbf @kylos101 @utam0k @sagor999 @roboquat