[dashboard] Hide PVC feature section when feat flag not set #11674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-af-hide-pvc-section.1 because the annotations in the pull request description changed |
|
/hold because it's based on #11672 |
andrew-farries
changed the title
Rather than having the section always visible but with a disable checkbox, hide the entire section if the feature flag is not set.
andrew-farries
force-pushed
the
af/hide-pvc-section
branch
from
ed16557
to
7c3d4da
Compare
|
/unhold |
sagor999
approved these changes
Jul 27, 2022
laushinka
approved these changes
Aug 1, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide the PVC feature section on the project settings page when the PVC feature flag is not set.
Previously, the section would always be visible but the checkbox would be disabled if the feature flag was not set.
Related Issue(s)
How to test
Disable the feature flag for users in non-production (via configcat) and reload a project settings page.
Release Notes
Documentation
Werft options: