Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Have spinner while loading #11687

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[usage] Have spinner while loading #11687

merged 1 commit into from
Jul 27, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Jul 27, 2022 •
edited

Description

This introduces a spinner when the data is being fetched.

Screenshot 2022-07-27 at 13 56 41

Related Issue(s)

Fixes #11677

How to test

  1. Join https://lau-loading-11677.preview.gitpod-dev.com/teams/join?inviteId=6dd143f5-9997-4e43-a1ef-1ba9edd2169b
  2. Set network conditions to Slow 3G
  3. Go to https://lau-loading-11677.preview.gitpod-dev.com/t/gitpod/usage

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-loading-11677.2 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka laushinka changed the title add spinner [usage] Have spinner while loading Jul 27, 2022
@laushinka laushinka marked this pull request as ready for review July 27, 2022 11:58
@laushinka laushinka requested a review from a team July 27, 2022 11:58
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 27, 2022
easyCZ
easyCZ approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@roboquat roboquat merged commit 3ee7764 into main Jul 27, 2022
@roboquat roboquat deleted the lau/loading-11677 branch July 27, 2022 12:09
@gtsiolis gtsiolis mentioned this pull request Jul 27, 2022
Closed
@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 27, 2022 •
edited

Thanks, @easyCZ & @laushinka! I've added a follow-up issue for updating the style changes introduced here, see #11696. I've also marked that as a ~good-first-issue as it feels it's ok to leave is out of the usage based epic and spend our efforts on more core changes.

@laushinka
Copy link
Contributor Author

laushinka commented Jul 27, 2022 •
edited by werft-gitpod-dev-com bot

I've added a follow-up issue

Thank you! 🙌🏽

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 28, 2022
@gtsiolis gtsiolis mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[usage] Adding loading state indicator when retrieving usage records
4 participants
@laushinka @gtsiolis @easyCZ @roboquat