Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openvsx alert #11717

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Add openvsx alert #11717

merged 1 commit into from
Jul 29, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Jul 28, 2022 •
edited by ArthurSens

Description

Add alert when openvsx registry is down

runbook: https://github.com/gitpod-io/runbooks/pull/292

Release Notes

NONE

Werft options:

  • /werft with-preview

@jeanp413 jeanp413 force-pushed the jp/openvsx-alert branch 3 times, most recently from 1d0fdd1 to e645fdd Compare July 28, 2022 07:42
@jeanp413 jeanp413 marked this pull request as ready for review July 28, 2022 07:43
@jeanp413 jeanp413 requested a review from a team July 28, 2022 07:43
@akosyakov
Copy link
Member

@ArthurSens Could you review please? It will be good start for us.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jp-openvsx-alert.5 because the annotations in the pull request description changed
(with .werft/ from main)

ArthurSens
ArthurSens approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my review, it should be good to go!

I added the hold just so you can address the review, feel free to remove and get this PR merged afterward :)

@jeanp413
Copy link
Member Author

/unhold

akosyakov
akosyakov approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s try

@roboquat roboquat merged commit eec7387 into main Jul 29, 2022
@roboquat roboquat deleted the jp/openvsx-alert branch July 29, 2022 04:46
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens approved these changes

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/M team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeanp413 @akosyakov @ArthurSens @roboquat