Revert the ws-daemon max unavailable back to wsdaemonMaxAttempts #11719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
|
How about checking if the underlying node is existing? |
Well, I want to decrease the time that ws-manager keeps in finalizeWorkspaceContent over 3 hours. |
aledbf
approved these changes
Jul 28, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Give the ws-daemon unavailable retry maximum be 2 mins.
We see in the production cluster, that once the ws-daemon is gone, probably due to the underlying node being gone.
We don't need to waste time to keep retrying it for 1 hour in such a case.
Somehow, the finalizeWorkspaceContent executes takes 3h14m, it not what we expected within 1 hour.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
None
Werft options: