Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] updating the refCache image in image-builder-mk3 #11727

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

This PR updates the workspace image name in the refCache of image-builder-mk3-config configmap when a custom workspace base image is provided in the installer config file. This means the correct base images are not cached, slightly slowing the image build.

Related Issue(s)

Fixes #11684

How to test

Create a Gitpod self hosted instance by opening a Gitpod workspace from main, making sure you have access to core-dev cluster and running: (you can read more about this preview setup here)

werft run github -j .werft/self-hosted-installer-tests.yaml -a skipTests=true -a preview=true -a deps=external

When the job is finished, you will get the URL and KUBECONFIG details under the get-results phase tab of the werft job.

Connect to KOTS UI by running kubectl kots admin-console -n gitpod, go to the config tab, tick the Enable advanced options and upload config patch with the following content:

workspace:
  workspaceImage: "gcr.io/sh-automated-tests/busybox:latest"
containerRegistry:
  privateBaseImageAllowList:
    - "gcr.io"

Redeploy as prompted. Once the setup is ready, check the refCache field in the configmap image-builder-mk3-config under gitpod namespace. You will see that it still shows workspace-full image.

Now update to the changes corresponding to this branch by doing the following(I have updated the changes to the dev-nan channel):

  • Go to replicated.com -> Customers -> dev-nan -> Download all licenses
  • In the KOTS UI, update the license to the downloaded file and redeploy.
  • You will now see the correct image in the refCache field

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma nandajavarma requested a review from a team July 28, 2022 13:35
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 28, 2022
@roboquat roboquat merged commit 20e91af into main Jul 28, 2022
@roboquat roboquat deleted the nvn/fix-11684 branch July 28, 2022 23:11
@mrsimonemms mrsimonemms mentioned this pull request Aug 3, 2022
1 task
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update custom workspace base image in image-builder-mk3 configmap
3 participants