[usage] Delay gRPC self connection #11747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The billing client tries to connect to the usage component gRPC server before the gRPC server is ready. This is a non-fatal error as gRPC dialing has built-in backoff/retry logic but it does produce ugly warnings in the usage component logs. Here we use a simple solution to delay the self-connection attempt for a short period to give the gRPC server time to start.
andrew-farries
changed the title
|
How does one know what delay is sufficient? I think possibly instead of this passing in a string address of the target service and the service establishes the connection the first time a request arrives may be easier to to deal with |
It doesn't. There is no synchronization, just a 'long enough' one second delay to give the gRPC server some time to start before the client makes the first connection attempt.
Not sure I follow. You mean don't have the client connect at startup but somehow do the connection on demand? |
easyCZ
approved these changes
Aug 1, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The billing client tries to connect to the usage component gRPC server before the gRPC server is ready. This is a non-fatal error as gRPC dialing has built-in backoff/retry logic but it does produce ugly warnings in the usage component logs.
Here we use a simple solution to delay the self-connection attempt for a short period to give the gRPC server time to start.
Related Issue(s)
Fixes #11743
How to test
Warning messages at
usagecomponent startup (as described in #11743) are no longer present.Release Notes
Documentation
Werft options: