Remove backup trail #11807
Merged
Remove backup trail #11807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
requested review from
csweichel,
geropl and
corneliusludmann
as code owners
github-actions
bot
added
team: delivery
mrsimonemms
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
LGTM
It's worth rebasing from main as this may fail due to #11288
Furisto
approved these changes
Aug 2, 2022
csweichel
reviewed
Aug 3, 2022
|
Other than the backwards incompatible config change this LGTM. |
csweichel
approved these changes
Aug 4, 2022
corneliusludmann
added a commit
that referenced
this pull request
Aug 4, 2022
1 task
roboquat
pushed a commit
that referenced
this pull request
Aug 4, 2022
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the backup trail feature. The feature is present only on GCP.
The reason for the removal is consistency with other providers and also to align it with PVC.
In traces, we see the error
Maximum number of snapshots (%d of %d) reachedmeaning we are not going to upload a backup for the workspace and the next time it is open, it will contain the previous state, not the last one.Related Issue(s)
Fixes #11709
Release Notes
Werft options: