-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add log when starting workspace with pvc #11824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold for question about log vs metric
log.info( | ||
{ | ||
lastInstanceId: lastValidWorkspaceInstanceId, | ||
volSnapshotId: volumeSnapshotId, | ||
snapshotId: volumeSnapshots.id, | ||
volumeHandle: volumeSnapshots.volumeHandle, | ||
workspaceId: workspace.id, | ||
}, | ||
"starting workspace with volume snapshot info", | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would a metric be more useful than a log message or is there already something in place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we kind of need log instead for debugging reasons.
/unhold |
Description
Related Issue(s)
Related #11823
How to test
Release Notes
Documentation
Werft options: