Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the Installer dependencies for every workspace #11829

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Get the Installer dependencies for every workspace #11829

merged 1 commit into from
Aug 3, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

Downloads the Installer dependencies at workspace-creation time so tests can be run.

Related Issue(s)

Fixes #11828

How to test

Start a workspace, cd install/installer then go test ./.... These should pass

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms force-pushed the mrsimonemms/cannot-run-installer-11828 branch from a028fcd to 8ed0f2a Compare August 3, 2022 08:08
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@mrsimonemms mrsimonemms marked this pull request as ready for review August 3, 2022 08:28
@mrsimonemms mrsimonemms mentioned this pull request Aug 3, 2022
Merged
1 task
iQQBot
iQQBot approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

another option is you can put this command in install/installer/cmd/testdata/render/README.md

@roboquat roboquat merged commit 367bbc7 into main Aug 3, 2022
@roboquat roboquat deleted the mrsimonemms/cannot-run-installer-11828 branch August 3, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

@corneliusludmann corneliusludmann Awaiting requested review from corneliusludmann

@mads-hartmann mads-hartmann Awaiting requested review from mads-hartmann

Assignees
No one assigned
Labels
release-note-none size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run Installer tests without getting dependencies
3 participants
@mrsimonemms @iQQBot @roboquat