Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve registry-facade HTTP requests resilience #11858

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Improve registry-facade HTTP requests resilience #11858

merged 2 commits into from
Aug 8, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 4, 2022 •
edited

Related Issue(s)

Fixes #11847

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf aledbf changed the title Update IPFS dependencies Improve registry-facade HTTP requests resilience Aug 4, 2022
@aledbf aledbf force-pushed the aledbf/ipfs branch 2 times, most recently from a2c493d to c6d324d Compare August 4, 2022 14:09
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-ipfs.32 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Aug 4, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-aledbf-ipfs.33
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review August 4, 2022 15:21
@aledbf aledbf requested review from a team August 4, 2022 15:21
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Aug 4, 2022
@csweichel
Copy link
Contributor

How can we test the retry mechanism, i.e. if the image pull succeeds?

@roboquat roboquat added size/XXL and removed size/XL labels Aug 4, 2022
@aledbf
Copy link
Member Author

aledbf commented Aug 4, 2022

How can we test the retry mechanism, i.e. if the image pull succeeds?

@csweichel please check the test

jenting
jenting reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good if we could add one test case that the retry maximum exceeds.

components/registry-facade/pkg/registry/http_client.go Outdated Show resolved Hide resolved
geropl
geropl approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geropl geropl self-assigned this Aug 5, 2022
@roboquat roboquat merged commit 7fd0492 into main Aug 8, 2022
@roboquat roboquat deleted the aledbf/ipfs branch August 8, 2022 13:15
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting left review comments

@mrsimonemms mrsimonemms mrsimonemms approved these changes

@csweichel csweichel csweichel approved these changes

@andrew-farries andrew-farries andrew-farries approved these changes

@sagor999 sagor999 sagor999 approved these changes

@mustard-mh mustard-mh mustard-mh approved these changes

@geropl geropl geropl approved these changes

Assignees

@geropl geropl

Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/XXL team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve getBlob resilience to remote disconnections
9 participants
@aledbf @csweichel @mrsimonemms @andrew-farries @sagor999 @mustard-mh @geropl @jenting @roboquat