-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[usage] Configure ingress for Stripe webhook #11866
Conversation
started the job as gitpod-build-af-ingress-for-stripe-webhook.10 because the annotations in the pull request description changed |
e1fe8a5
to
476b887
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold
for Q about generated file
@@ -1424,8 +1424,7 @@ data: | |||
"gcloud": { | |||
"credentialsFile": "", | |||
"region": "", | |||
"projectId": "", | |||
"maximumBackupCount": 0 | |||
"projectId": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to your change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. The file was regenerated with make generateRenderTests
following the README.
I don't know what accounts for the changes in the file besides the change to the proxy config. Maybe the file was not updated by a previous PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess Self-Hosted is on the review and can clarify. Perhaps we're missing a CI check that would fail if the output.golden
doesn't match anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good and happy to approve. We've just had a change merged which updated the render golden files so probably worth rebasing (again) as it's likely to fail when merged to main
.
Remove the hold at will
/hold
Allow ingress from proxy to the http port 9002.
476b887
to
6f19635
Compare
Rebased and tests pass so /unhold |
Description
Configures ingress between
proxy
and the public API server to allow external access to the Stripe webhook (added in #11806).backend
section to thepayment-ingress
section in the proxyCaddyfile
andnetworkpolicy
to allowproxy
to reach thepublic-api-server
.Related Issue(s)
Part of #10937
How to test
Expected output:
Release Notes
Documentation
Werft options: