Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpctl] Add workspace type to workspaces list #11870

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Aug 4, 2022

Description

Add Type and Pod to output of workspaces list. This allows on-callers responding to https://github.com/gitpod-io/runbooks/blob/main/runbooks/GitpodWorkspaceStuckOnStarting.md more easily understand the type of workspace

Related Issue(s)

Fixes #

How to test

  1. Get kube context
  2. Run cd dev/gpctl && go run main.go workspaces list
  3. Observe the output columns containing type and pod.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@roboquat roboquat added size/M and removed size/S labels Aug 4, 2022
@easyCZ easyCZ marked this pull request as ready for review August 4, 2022 09:50
@easyCZ easyCZ requested a review from a team August 4, 2022 09:50
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 4, 2022
@Furisto
Copy link
Member

Furisto commented Aug 4, 2022

Nice! I like the addition of the type, not so sure about including the pod name. The pod name is ws|prebuild + instanceid and we already have the instance id in the third column and now we also have the type, so the pod name does not convey any new information.

@easyCZ
Copy link
Member Author

easyCZ commented Aug 4, 2022

@Furisto That's fair. And I'd expect that from workspace team engineers. But with engineers from other teams being on-call for these, they are not always aware of the mapping between a workspace type and instance. Even here it's non-obvious because Regular workspaces use ws while prebuilds do use the full prebuild.

For me personally, this would've saved me a bunch of time during on-call, and especially during the first time handling the alert as I wasn't directly aware of the mapping between ws type and pod.

@easyCZ
Copy link
Member Author

easyCZ commented Aug 4, 2022

As another data point, this came up during Week 31 on-call, (internal) thread here

@Furisto
Copy link
Member

Furisto commented Aug 4, 2022

I see. We should have a FAQ kind of document that explains these things. Until we have that I am fine with including the pod name. cc @kylos101 for awareness

@roboquat roboquat merged commit e3452c7 into main Aug 4, 2022
@roboquat roboquat deleted the mp/workspace-list-type branch August 4, 2022 10:45
@utam0k utam0k mentioned this pull request Aug 5, 2022
1 task
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants