[installer] Ensure stable ordering of rendered K8s objects #11879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusludmann
force-pushed
the
clu/render-stable-order
branch
from
b032929
to
c3c8559
Compare
corneliusludmann
force-pushed
the
clu/render-stable-order
branch
from
c3c8559
to
b75ce17
Compare
github-actions
bot
added
team: IDE
team: webapp
mrsimonemms
approved these changes
Aug 5, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the ordering of the rendered K8s objects is stable. That allows comparing renderings with different configs.
How to test
Render with 2 different configs (e.g. with external registry and with internal registry). Without this change, the ordering is not stable and it is impossible to compare the changes. After this change, the ordering is stable and you can see with a diff what has changed in the rendering.
#11880 has an example where you can compare the golden files with and without an external registry.
Release Notes
Werft options: