Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Support setting billInstancesAfter #11883

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

In #11882 the usage component gained a billInstancesAfter config setting, to better support the rollout of usage based pricing.

This PR adds the ability to set billInstancesAfter through the installer.

Related Issue(s)

Part of #10937

How to test

Automated installer tests.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

Andrew Farries added 2 commits August 4, 2022 10:28
Add a new config setting to the usage component.

`billInstancesAfter` sets the date after which instances should be
considered for billing - instances started before `billInstancesAfter`
will not be considered by the billing controller.
Add the ability to set the usage controller `BillInstancesAfter` config.
@andrew-farries
Copy link
Contributor Author

/hold because it's based on #11882

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGMT! 🙏

Base automatically changed from af/no-billing-for-old-instances to main August 5, 2022 12:47
@roboquat roboquat added size/L and removed size/M labels Aug 5, 2022
@andrew-farries
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit ba65d4a into main Aug 5, 2022
@roboquat roboquat deleted the af/installer-support-billinstancesafter branch August 5, 2022 12:52
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/L team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants