Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] build stable code image for 1.70 #11899

Merged
merged 1 commit into from
Aug 5, 2022
Merged

[code] build stable code image for 1.70 #11899

merged 1 commit into from
Aug 5, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Aug 5, 2022

Description

Build code image for 1.7.0

Build result https://werft.gitpod-dev.com/job/gitpod-build-hw-vs-170-build.3/results

Related Issue(s)

Fixes #
Relates #11638

How to test

  • Switch to VS Code Insiders in settings.
  • Start a workspace.
  • Test following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded on the PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-vs-170-build.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

/hold

To test first

@mustard-mh
Copy link
Contributor Author

/unhold

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@roboquat roboquat merged commit dc6418b into main Aug 5, 2022
@roboquat roboquat deleted the hw/vs-170-build branch August 5, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants