Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UBP] Add FinalizeInvoice RPC to billing service #11903

Merged
merged 2 commits into from
Aug 5, 2022
Merged

[UBP] Add FinalizeInvoice RPC to billing service #11903

merged 2 commits into from
Aug 5, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Add a FinalizeInvoice RPC to the billing service.

This will:

  • be invoked by the Stripe webhook handler ([public-api] Add a placeholder Stripe webhook #11806) whenever an invoice finalizes.
  • retrieve the corresponding usage report for the invoice from object storage
  • mark all sessions in the report as being part of the invoice, to avoid them being included in any subsequent invoices.

The PR just adds the .proto changes to define the RPC.

Related Issue(s)

Part of #10937

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

Andrew Farries added 2 commits August 5, 2022 05:56
Update billing.proto
d4522bf 
Add FinalizeInvoice RPC.
Run ./generate.sh
9fece4e
@andrew-farries andrew-farries requested a review from a team August 5, 2022 07:07
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 5, 2022
@roboquat roboquat merged commit bc6c018 into main Aug 5, 2022
@roboquat roboquat deleted the af/proto-for-invoice-finalization branch August 5, 2022 07:56
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 5, 2022
@andrew-farries andrew-farries mentioned this pull request Aug 9, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-farries @easyCZ @roboquat