Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prebuild workspace class for regular workspaces #11912

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Aug 5, 2022

Description

Ensure that if a prebuild is used to create a workspace a class is used that is appropriate for the workspace; meaning if the prebuild has a workspace class greater than the currently configured one by the customer the prebuild class is used, otherwise the class configured by the customer is used.

Related Issue(s)

Fixes ##11972
Needs https://github.com/gitpod-io/ops/pull/3728

How to test

  • Select workspace class g1-large
  • Start a prebuild
  • Select workspace class g1-standard
  • Create a regular workspace from prebuild
  • The workspace should have g1-large
    --
  • Start a prebuild for another repository (with g1-standard)
  • Select workspace class g1-large
  • Create a regular workspace from prebuild
  • The workspace should have g1-large

Release Notes

None

Documentation

Werft options:

  • /werft with-preview

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-fo-prebuild-class.2 because the annotations in the pull request description changed
(with .werft/ from main)

@Furisto Furisto force-pushed the fo/prebuild-class branch 4 times, most recently from 85b298f to d948fa6 Compare August 7, 2022 18:05
@roboquat roboquat added size/XXL and removed size/XL labels Aug 7, 2022
@Furisto Furisto force-pushed the fo/prebuild-class branch 3 times, most recently from f0e246d to f80febd Compare August 8, 2022 13:30
@roboquat roboquat added size/XL and removed size/XXL labels Aug 8, 2022
@Furisto Furisto requested a review from a team August 8, 2022 18:58
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 8, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 8, 2022

if the prebuild has a workspace class greater than the currently configured one by the customer the prebuild class is used

Apologies for the drive-by thought, but can't this have potentially unwanted consequences like:

  • one user prefers XL but has also set up Prebuilds for a project, thus "forcing" every project member to also use XL?
  • a team on a business plan using XL for an open source project, thus accidentally forcing every external contributor to also use XL?

Not blocking for this PR, but we'll probably need to figure out a good UX for these cases. 🤔

@Furisto
Copy link
Member Author

Furisto commented Aug 8, 2022

@jankeromnes You are absolutely correct. This needs better UX, but we will enable this feature for only a very limited number of customers first, where it is understood that this is the current behavior. See https://gitpod.slack.com/archives/C02F19UUW6S/p1659639905273709 for some internal discussion about this.

@laushinka
Copy link
Contributor

laushinka commented Aug 11, 2022

/werft run

👍 started the job as gitpod-build-fo-prebuild-class.16
(with .werft/ from main)

Copy link
Contributor

@laushinka laushinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@roboquat roboquat merged commit 8b931f4 into main Aug 11, 2022
@roboquat roboquat deleted the fo/prebuild-class branch August 11, 2022 11:49
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production feature: workspace classes release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants