-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prebuild workspace class for regular workspaces #11912
Conversation
started the job as gitpod-build-fo-prebuild-class.2 because the annotations in the pull request description changed |
df92cde
to
258bfbc
Compare
85b298f
to
d948fa6
Compare
f0e246d
to
f80febd
Compare
f80febd
to
41b43fc
Compare
41b43fc
to
d03fce3
Compare
Apologies for the drive-by thought, but can't this have potentially unwanted consequences like:
Not blocking for this PR, but we'll probably need to figure out a good UX for these cases. 🤔 |
@jankeromnes You are absolutely correct. This needs better UX, but we will enable this feature for only a very limited number of customers first, where it is understood that this is the current behavior. See https://gitpod.slack.com/archives/C02F19UUW6S/p1659639905273709 for some internal discussion about this. |
/werft run 👍 started the job as gitpod-build-fo-prebuild-class.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised!
Description
Ensure that if a prebuild is used to create a workspace a class is used that is appropriate for the workspace; meaning if the prebuild has a workspace class greater than the currently configured one by the customer the prebuild class is used, otherwise the class configured by the customer is used.
Related Issue(s)
Fixes ##11972
Needs https://github.com/gitpod-io/ops/pull/3728
How to test
--
Release Notes
Documentation
Werft options: