Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore git error message does not have any commits yet #11938

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Aug 6, 2022

Description

If the git repo has no commits, the git log displays does not have any commits yet. We ignore it in tracing.

Related Issue(s)

Fixes #11789

How to test

  1. Open repo github.com/gitpod-io/emtpy
  2. Check jaeger tracing, making sure there is no tracing error in git.log span.

Release Notes

None

Documentation

None

Werft options:

  • /werft with-preview

If the git repo has no commits, the git log displays `does not have any
commits yet`. We ignore it in tracing.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting marked this pull request as ready for review August 6, 2022 02:39
@jenting jenting requested a review from a team August 6, 2022 02:39
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 6, 2022
@roboquat roboquat merged commit 899d149 into main Aug 8, 2022
@roboquat roboquat deleted the jenting/ws-daemon-git-log-pretty-11789 branch August 8, 2022 01:09
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-daemon] git log --pretty=%H -n 1 failed
3 participants