Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error to the client and only ignore tracing error #11939

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Aug 6, 2022

Description

Return error to the client and only ignore tracing error.

Related Issue(s)

Fixes #11710
Fixes #11713

How to test

None

Release Notes

None

Documentation

None

Werft options:

  • /werft with-preview

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting requested a review from a team August 6, 2022 02:42
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 6, 2022
@roboquat roboquat merged commit 9017476 into main Aug 6, 2022
@roboquat roboquat deleted the jenting/11710 branch August 6, 2022 22:18
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
3 participants