registry-facade: Remove unnecessary varilable declaration. #11948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: workspace
jenting
reviewed
Aug 8, 2022
| @@ -359,8 +359,7 @@ func (sbs ipfsBlobSource) HasBlob(ctx context.Context, spec *api.ImageSpec, dgst | |||
| func (sbs ipfsBlobSource) GetBlob(ctx context.Context, spec *api.ImageSpec, dgst digest.Digest) (dontCache bool, mediaType string, url string, data io.ReadCloser, err error) { | |||
| log := log.WithField("digest", dgst) | |||
|
|
|||
| var ipfsCID string | |||
| ipfsCID, err = sbs.source.Redis.Get(ctx, dgst.String()).Result() | |||
| ipfsCID, err := sbs.source.Redis.Get(ctx, dgst.String()).Result() | |||
There was a problem hiding this comment.
This is intended, because we declare the err variable at line 359.
Otherwise, we can't catch this line's error and update to line 359 err variable.
There was a problem hiding this comment.
Otherwise, we can't catch this line's error and update to line 359 err variable.
Oh, I didn't know that. So you are saying that we can't use err for return value?
There was a problem hiding this comment.
Oops, sorry my bad, I did not see at line 365, we set the error as err = distv2.ErrorCodeBlobUnknown.
jenting
approved these changes
Aug 8, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
just small refactoring
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: