Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBP] Add placeholder implementation of FinalizeInvoice #11949

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Aug 8, 2022

Description

Add a trivial 'noop' implementation of FinalizeInvoice to the billing RPC service.

Related Issue(s)

Part of #10937

How to test

  • Unit test for the billing service
    or
  • Port-forward to the usage service gRPC server:
kubectl port-forward svc/usage 9001:9001
  • Use evans or grpcurl to hit the placeholder FinalizeInvoice RPC with an invoice id of e.g: 1234
  • Tail the logs of deploy/usage and see:
{"level":"info","message":"Finalizing invoice for invoice \"1234\"","serviceContext":{"service":"usage","version":"commit-0aa8abfc2d3b27707a248d3ab285d3561202ceab"},"severity":"INFO","time":"2022-08-08T07:27:39Z"}

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@andrew-farries andrew-farries requested a review from a team August 8, 2022 07:29
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 8, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-placeholder-finalize-invoice-impl.4 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka
Copy link
Contributor

Taking a look!

@laushinka
Copy link
Contributor

This is so cool
Screenshot 2022-08-10 at 14 43 26

@roboquat roboquat merged commit 8a8d2ea into main Aug 10, 2022
@roboquat roboquat deleted the af/placeholder-finalize-invoice-impl branch August 10, 2022 12:48
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants