Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle for compatibility with Java 17 #11991

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Aug 9, 2022

Description

Currently, when we open Gitpod Workspace, it displays warnings about not being able to use the installed version of Gradle with Java 17 and asking us to upgrade it to v7.3.1:

image

These notifications come from Language Support for Java extension from VS Code. And this PR contains the modifications generated by it.

Related Issue(s)

None.

How to test

  1. Open the preview environment generated for this branch
  2. Choose the stable version of IntelliJ IDEA as your preferred editor
  3. Start a workspace using this repository: https://github.com/gitpod-io/spring-petclinic
  4. Verify that the workspace starts successfully
  5. Verify that the IDE opens successfully

image

Release Notes

NONE

Documentation

None.

Werft options:

  • /werft with-preview

@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Aug 9, 2022
@felladrin felladrin self-assigned this Aug 9, 2022
@felladrin felladrin marked this pull request as ready for review August 9, 2022 17:52
@felladrin felladrin requested a review from a team August 9, 2022 17:52
@felladrin felladrin changed the title Upgrade Gradle Wrapper for compatibility with Java 17 Upgrade Gradle for compatibility with Java 17 Aug 9, 2022
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected ✅

@akosyakov
Copy link
Member

I'm not sure why my review or Chris is required here.

@roboquat roboquat merged commit 232e85a into main Aug 10, 2022
@roboquat roboquat deleted the felladrin/upgrade-gradle-wrapper-for-java-17 branch August 10, 2022 05:48
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XXL team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants